Review Request for JDK-8006304

[Marcus Lagergren]

Especially http://kenai.com/jira/browse/NASHORN-410 and http://kenai.com/jira/browse/NASHORN-501 in their original bug-producing form would be nice to have as unit tests. Both repros are attached to respective CRs.

On Jan 16, 2013, at 7:23 AM, Marcus Lagergren <marcus.lagergren at oracle.com> wrote:

> More parts of the TODO fix? Perhaps get rid of the FunctionNode.thisProperties collection altogether? 
> 
> I agree with what sundar Says to add unit tests for all varieties of this bug if possible. Regarding the one Hannes filed yesterday with env.js & query:  I'm not sure what the status of env.js is but jquery is approved for inclusion in the external test suite.
> 
> Otherwise +1
> 
> On Jan 16, 2013, at 5:04 AM, A. Sundararajan <sundararajan.athijegannathan at oracle.com> wrote:
> 
>> +1
>> 
>> PS. There were other variants of the conditional constructor path tests - I recall at least 3 bugs. Do we want to add few variants to test ?
>> 
>> -Sundar
>> 
>> Jim Laskey (Oracle) wrote:
>>> - CodeGenerator.java is marked TODO because the real fix requires major surgery that will come with further property map work.  This interim fix should address several pending bugs related to premature constructor properties.
>>> 
>>> - Plus two unrelated items found along the way, missing eoln on .hgignore and misspelling in FunctionObjectCreator.java .
>>> 
>>> http://cr.openjdk.java.net/~jlaskey/8006304/webrev/index.html
>>> 
>>> 
>> 
>