Review request JDK-8006527 : nashorn jsr223 engine does not work in sandbox

[Attila Szegedi]

Looks good to me.

One thing that I noticed is that we aren't closing the stream in evalSupportScript. I suspect it's mostly moot as it comes from the .jar file, and will get GC'd anyway soon. It was there before, so it's not an argument against your patch, just something that you maybe can still sneak into this issue. If not, doesn't matter.

On Jan 17, 2013, at 6:12 PM, "A. Sundararajan" <sundararajan.athijegannathan at oracle.com> wrote:

> Hi,
> 
> Fixed missing copyrights in new scripts (engine.js and jsadapter.js). Please review the updated webrev
> 
> http://cr.openjdk.java.net/~sundar/8006527/webrev.01/
> 
> Thanks
> -Sundar
> 
> On Thursday 17 January 2013 10:30 PM, Jim Laskey (Oracle) wrote:
>> +1
>> 
>> On 2013-01-17, at 12:52 PM, "A. Sundararajan" <sundararajan.athijegannathan at oracle.com> wrote:
>> 
>>> Hi,
>>> 
>>> Please review http://cr.openjdk.java.net/~sundar/8006527/
>>> 
>>> Thanks
>>> -Sundar
>