Review request JDK-8007132: Java objects returned from constructor functions are lost

Marcus Lagergren marcus.lagergren at oracle.com
Wed Jan 30 03:41:50 PST 2013


+1

On Jan 30, 2013, at 12:23 PM, A. Sundararajan <sundararajan.athijegannathan at oracle.com> wrote:

> Hi,
> 
> Please review updated webrev @ http://cr.openjdk.java.net/~sundar/8007132/webrev.01/
> 
> Thanks
> -Sundar
> 
> On Wednesday 30 January 2013 03:32 PM, Hannes Wallnoefer wrote:
>> Looks good.  You have some added whitespace there.
>> 
>> Maybe add a test for using a function returning a primitive as constructor? I guess it should be covered by test262, but you never know.
>> 
>> Hannes
>> 
>> Am 2013-01-30 10:42, schrieb A. Sundararajan:
>>> Hi,
>>> 
>>> Please review http://cr.openjdk.java.net/~sundar/8007132/
>>> 
>>> Thanks
>>> -Sundar
>> 
> 



More information about the nashorn-dev mailing list