Review request for JDK-8006529

[Jim Laskey (Oracle)]

FinalizeTypes.java

 549     private static void updateSymbols(final Block block) {
 550         if (block instanceof FunctionNode && block.getFunction() == block) {

Why not a visitor (instead of instanceof test)?
and Shouldn't it be?

 549     private static void updateSymbols(final Block block) {
 550         if (block instanceof FunctionNode) {
 551              assert block.getFunction() == block;


I have to say jdk.nashorn.internal.codegen.CompilerAccess creeps me out a bit.  Since it's for testing only, it should not get into fcs build.


+1 otherwise.


On 2013-01-30, at 11:53 AM, Attila Szegedi <attila.szegedi at oracle.com> wrote:

> Please review JDK-8006529 at http://cr.openjdk.java.net/~attila/8006529/webrev.00
> 
> Thanks,
>  Attila.