Please review JDK-8060204

A. Sundararajan sundararajan.athijegannathan at oracle.com
Mon Nov 3 08:25:02 UTC 2014


+1

Please run "ant javadoc" and "ant javadocapi". I recall couple of -> 
character issues in couple of places (and hence javadoc target build 
failed - even before your changes.).

-Sundar

On Monday 03 November 2014 12:02 PM, Attila Szegedi wrote:
> Indentation in JSObjectLinker @@ -120,12 +120,10 @@ change looks odd. Other than that, +1.
>
> On Nov 2, 2014, at 4:31 PM, Marcus Lagergren <marcus.lagergren at oracle.com> wrote:
>
>> Please review JDK-8060204 - Remove warnings in Joni and other places
>>
>> Got rid of ~1400 warnings
>>
>> Webrev at: http://cr.openjdk.java.net/~lagergren/8060204/ <http://cr.openjdk.java.net/~lagergren/8060204/>
>>
>> /M



More information about the nashorn-dev mailing list