Please review JDK-8060204

Hannes Wallnoefer hannes.wallnoefer at oracle.com
Mon Nov 3 08:56:49 UTC 2014


Wow, this is one massive cleanup!

To my knowledge we still have a blank line between static and non-static 
imports, right? Based on that, below is my list of nitpicks.

Otherwise +1.

objects/ArrayBufferView:
linker/BrowserJSObjectLinker:
joni/ast/QuantifierNode:
joni/Analyzer:
joni/ArrayCompiler:
joni/ByteCodeMachine:
joni/Lexer:
joni/Matcher:
joni/Parser:
joni/ScanEnvironment:
joni/StackMachine:
joni/Syntax:
runtime/RecompilableScriptFunctionData:
plus many test classes:
     Keep black line between static and normal imports.

linker/JSObjectLinker:
     Indentation of former else branch in line 124

joni/ast/Node:
     Indentation of getChild end bracket

joni/ByteCodeMachine:
     opening bracket in new line in line 882

joni/Matcher:
     please preserve /* check only */ comment

test/.../OctaneTest:
    you're adding tests for mandreel, typescript and zlib - not sure if 
this is intentional?



Am 2014-11-02 um 16:31 schrieb Marcus Lagergren:
> Please review JDK-8060204 - Remove warnings in Joni and other places
>
> Got rid of ~1400 warnings
>
> Webrev at: http://cr.openjdk.java.net/~lagergren/8060204/ <http://cr.openjdk.java.net/~lagergren/8060204/>
>
> /M



More information about the nashorn-dev mailing list