Review request for JDK-8059844

Attila Szegedi attila.szegedi at oracle.com
Mon Oct 20 10:48:07 UTC 2014


Folks,

I had to make minor adjustments for this patch when backporting it to 8. The reason is that constructors for FunctionNode differ in 9 and 8 after JDK-8012518 (bottom up parser), which is a 9-only change (and so the divergence begins…)

A difference between the 9 and 8 codebase is available at <http://cr.openjdk.java.net/~attila/8059844/webrev-8-backport/index.html>. Could you please review it? It's only a change in the modified constructors' invocations.

Thanks,
  Attila.

On Oct 17, 2014, at 2:23 PM, Hannes Wallnoefer <hannes.wallnoefer at oracle.com> wrote:

> +1 for webrev.02. Good work keeping recompilation overhead at reasonable levels!
> 
> Hannes
> 
> Am 2014-10-07 um 13:52 schrieb Attila Szegedi:
>> Please review JDK-8059844 at <http://cr.openjdk.java.net/~attila/8059844/webrev.00> for <https://bugs.openjdk.java.net/browse/JDK-8059844>
>> 
>> Thanks,
>>   Attila.
> 



More information about the nashorn-dev mailing list