Review request for JDK-8059813: Type Info Cache flag must must be documented
Hannes Wallnoefer
hannes.wallnoefer at oracle.com
Thu Oct 23 09:01:06 UTC 2014
Thanks Attila,
I've uploaded a new webrev with the changes you suggested.
http://cr.openjdk.java.net/~hannesw/8059813/webrev.01/
Hannes
Am 2014-10-22 um 19:13 schrieb Attila Szegedi:
> s/that make sure/that makes sure in DEVELOPER_README
>
> I'd maybe remove documentation for nashorn.typeInfo.disabled; I actually planned on removing that property, and let only nashorn.typeInfo.maxFiles govern whether it's enabled or disabled. Can we do that (even though the property is there?)
>
> nashorn.args.prepend: how about emphasizing that later options overwrite earlier ones, so .prepend is useful for setting defaults that can be overwritten
>
> Other than these remarks, +1.
>
>
> On Oct 22, 2014, at 6:34 PM, Hannes Wallnoefer <hannes.wallnoefer at oracle.com> wrote:
>
>> Please review JDK-8059813: Type Info Cache flag must must be documented:
>>
>> http://cr.openjdk.java.net/~hannesw/8059813/
>>
>> Thanks,
>> Hannes
More information about the nashorn-dev
mailing list