Review request for JDK-8059813: Type Info Cache flag must must be documented

[Attila Szegedi]

I found another one that needs to be documented:

-Dnashorn.typeInfo.cacheDir

This property can be used to set the directory where Nashorn stores the
type info cache when -Dnashorn.typeInfo.maxFiles is set to a nonzero 
value. The default location is platform specific. On Windows, it is 
"${java.io.tmpdir}\com.oracle.java.NashornTypeInfo". On Linux and 
Solaris it is "~/.cache/com.oracle.java.NashornTypeInfo". On Mac OS X, 
it is "~/Library/Caches/com.oracle.java.NashornTypeInfo".


On Oct 23, 2014, at 11:01 AM, Hannes Wallnoefer <hannes.wallnoefer at oracle.com> wrote:

> Thanks Attila,
> 
> I've uploaded a new webrev with the changes you suggested.
> 
> http://cr.openjdk.java.net/~hannesw/8059813/webrev.01/
> 
> Hannes
> 
> Am 2014-10-22 um 19:13 schrieb Attila Szegedi:
>> s/that make sure/that makes sure in DEVELOPER_README
>> 
>> I'd maybe remove documentation for nashorn.typeInfo.disabled; I actually planned on removing that property, and let only nashorn.typeInfo.maxFiles govern whether it's enabled or disabled. Can we do that (even though the property is there?)
>> 
>> nashorn.args.prepend: how about emphasizing that later options overwrite earlier ones, so .prepend is useful for setting defaults that can be overwritten
>> 
>> Other than these remarks, +1.
>> 
>> 
>> On Oct 22, 2014, at 6:34 PM, Hannes Wallnoefer <hannes.wallnoefer at oracle.com> wrote:
>> 
>>> Please review JDK-8059813: Type Info Cache flag must must be documented:
>>> 
>>> http://cr.openjdk.java.net/~hannesw/8059813/
>>> 
>>> Thanks,
>>> Hannes
>