[PATCH] Delete testng.zip after extraction

Ahmed Ashour asashour at yahoo.com
Thu Jul 9 10:09:12 UTC 2015


Hi again,
I would withdraw the below patch.
Somehow the .zip is referenced by -test-nosecurity target, and I couldn't easily find where exactly.
Ahmed      From: Ahmed Ashour <asashour at yahoo.com>
 To: Nashorn-dev <nashorn-dev at openjdk.java.net> 
 Sent: Thursday, July 9, 2015 11:32 AM
 Subject: [PATCH] Delete testng.zip after extraction
   
Hi all,
As you know, the ant target 'get-testng' is meant to extract .jar file from .zip file from internet.
However, it leaves the downloaded file 'testng-6.8.zip', which is not needed after the extraction.
This affects the working project status (e.g. patch creation), as that file will be marked as something new.
Another solution:  would be to add the .zip file to .hgignore, but I think deleting the .zip is better.
Please find the below relevant patch.
Thanks,Ahmed


diff -r 3cb11f4d617e make/build.xml--- a/make/build.xml    Wed Jul 08 17:28:08 2015 +0530+++ b/make/build.xml    Thu Jul 09 11:28:44 2015 +0200@@ -755,6 +755,7 @@     </unzip>     <move file="${test.lib}${file.separator}testng-6.8${file.separator}testng-6.8.jar" tofile="${test.lib}${file.separator}testng.jar"/>     <delete dir="${test.lib}${file.separator}testng-6.8"/>+       <delete file="${test.lib}${file.separator}testng-6.8.zip"/>   </target>
   <!-- run all tests -->


  


More information about the nashorn-dev mailing list