[PATCH] Delete testng.zip after extraction

[Michael Haupt]

Hi Ahmed,

thanks for pointing this out; I'll add the file to .hgignore.
https://bugs.openjdk.java.net/browse/JDK-8130862

BTW the -test-nosecurity target just completed happily for me without the ZIP file being around. It would help if you could indicate the nature of the problem you've encountered.

Best,

Michael

> Am 09.07.2015 um 12:09 schrieb Ahmed Ashour <asashour at yahoo.com>:
> 
> Hi again,
> I would withdraw the below patch.
> Somehow the .zip is referenced by -test-nosecurity target, and I couldn't easily find where exactly.
> Ahmed      From: Ahmed Ashour <asashour at yahoo.com>
> To: Nashorn-dev <nashorn-dev at openjdk.java.net> 
> Sent: Thursday, July 9, 2015 11:32 AM
> Subject: [PATCH] Delete testng.zip after extraction
> 
> Hi all,
> As you know, the ant target 'get-testng' is meant to extract .jar file from .zip file from internet.
> However, it leaves the downloaded file 'testng-6.8.zip', which is not needed after the extraction.
> This affects the working project status (e.g. patch creation), as that file will be marked as something new.
> Another solution:  would be to add the .zip file to .hgignore, but I think deleting the .zip is better.
> Please find the below relevant patch.
> Thanks,Ahmed
> 
> 
> diff -r 3cb11f4d617e make/build.xml--- a/make/build.xml    Wed Jul 08 17:28:08 2015 +0530+++ b/make/build.xml    Thu Jul 09 11:28:44 2015 +0200@@ -755,6 +755,7 @@     </unzip>     <move file="${test.lib}${file.separator}testng-6.8${file.separator}testng-6.8.jar" tofile="${test.lib}${file.separator}testng.jar"/>     <delete dir="${test.lib}${file.separator}testng-6.8"/>+       <delete file="${test.lib}${file.separator}testng-6.8.zip"/>   </target>
>    <!-- run all tests -->
> 
> 
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment>	Oracle is committed to developing practices and products that help protect the environment