RFR 8130888: Typos in nashorn sources [was Re: [PATCH] typos]
Michael Haupt
michael.haupt at oracle.com
Fri Jul 10 06:41:48 UTC 2015
Hi,
here's a lower-case review. Just one remark: in OptionTemplate, the comment should end in "... if none exists" instead of "... if non exists". Otherwise this looks good. Thank you, Ahmed!
Funny: the diff for NativeFunction.java is empty in the Udiff view, but there is a patch. Apparently just one space was removed.
Best,
Michael
> Am 10.07.2015 um 05:07 schrieb A. Sundararajan <sundararajan.athijegannathan at oracle.com>:
>
> Hi,
>
> Please review http://cr.openjdk.java.net/~sundar/8130888/ for https://bugs.openjdk.java.net/browse/JDK-8130888
>
> Hi Ahmed,
>
> No problem! Initial problems are normal :) Thanks for the contribution!
>
> -Sundar
--
<http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
<http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
More information about the nashorn-dev
mailing list