RFR 8130888: Typos in nashorn sources [was Re: [PATCH] typos]

A. Sundararajan sundararajan.athijegannathan at oracle.com
Fri Jul 10 07:22:16 UTC 2015


Thanks Michael! Yes, NativeFunction has one whitespace change :)

Thanks
-Sundar

On Friday 10 July 2015 12:11 PM, Michael Haupt wrote:
> Hi,
>
> here's a lower-case review. Just one remark: in OptionTemplate, the comment should end in "... if none exists" instead of "... if non exists". Otherwise this looks good. Thank you, Ahmed!
>
> Funny: the diff for NativeFunction.java is empty in the Udiff view, but there is a patch. Apparently just one space was removed.
>
> Best,
>
> Michael
>
>> Am 10.07.2015 um 05:07 schrieb A. Sundararajan <sundararajan.athijegannathan at oracle.com>:
>>
>> Hi,
>>
>> Please review http://cr.openjdk.java.net/~sundar/8130888/ for https://bugs.openjdk.java.net/browse/JDK-8130888
>>
>> Hi Ahmed,
>>
>> No problem! Initial problems are normal :) Thanks for the contribution!
>>
>> -Sundar
>



More information about the nashorn-dev mailing list