RFR 8136349: Typos patch for nashorn sources submitted on Sep 10, 2015

Hannes Wallnoefer hannes.wallnoefer at oracle.com
Fri Sep 11 08:46:47 UTC 2015


Looks good.

I'm not sure "undefineds" is a valid plural form of "undefined" in 
UndefinedArrayFilter, maybe use "undefined slots"?

Hannes

Am 2015-09-11 um 09:52 schrieb Sundararajan Athijegannathan:
> Please review http://cr.openjdk.java.net/~sundar/8136349/ for 
> https://bugs.openjdk.java.net/browse/JDK-8136349
>
> This is a contribution by Ahmed Ashour. Please see this thread -> 
> http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-September/005206.html
>
> This webrev was generated by after applying Ahmed's patch & then 
> fixing the following manually on top of that:
>
> 1) File: NativeRegExp.java
>
>     preceds -> precedes
>
> 2) File: CompiledFunction.java
>
>     rest of -> "restOf" - this is a reference to "restOf" methods 
> generated and so should not be "rest of".
>
> Thanks,
> -Sundar



More information about the nashorn-dev mailing list