RFR 8136349: Typos patch for nashorn sources submitted on Sep 10, 2015
Marcus Lagergren
lagergren at gmail.com
Fri Sep 11 09:03:05 UTC 2015
+1.
I might be a bit slow, or it’s a Swedish/German culture gap or something, but Michael, this “lower case” that you have before thumbs up - what does it mean? :)
/M
> On 11 Sep 2015, at 10:28, Michael Haupt <michael.haupt at oracle.com> wrote:
>
> Hi Sundar,
>
> lower-case thumbs up!
>
> Best,
>
> Michael
>
>> Am 11.09.2015 um 09:52 schrieb Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com>:
>>
>> Please review http://cr.openjdk.java.net/~sundar/8136349/ for https://bugs.openjdk.java.net/browse/JDK-8136349
>>
>> This is a contribution by Ahmed Ashour. Please see this thread -> http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-September/005206.html
>>
>> This webrev was generated by after applying Ahmed's patch & then fixing the following manually on top of that:
>>
>> 1) File: NativeRegExp.java
>>
>> preceds -> precedes
>>
>> 2) File: CompiledFunction.java
>>
>> rest of -> "restOf" - this is a reference to "restOf" methods generated and so should not be "rest of".
>>
>> Thanks,
>> -Sundar
>
> --
>
> <http://www.oracle.com/>
> Dr. Michael Haupt | Principal Member of Technical Staff
> Phone: +49 331 200 7277 | Fax: +49 331 200 7561
> Oracle Java Platform Group | LangTools Team | Nashorn
> Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
> <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
>
More information about the nashorn-dev
mailing list