Review request for JDK-8134490: Dead var statement evacuation incorrectly descends into nested functions

Hannes Wallnoefer hannes.wallnoefer at oracle.com
Fri Sep 25 10:24:41 UTC 2015


+1

Am 2015-09-24 um 17:16 schrieb Attila Szegedi:
> Please review JDK-8134490 "Dead var statement evacuation incorrectly descends into nested functions" at <http://cr.openjdk.java.net/~attila/8134490/webrev.jdk9> for <https://bugs.openjdk.java.net/browse/JDK-8134490>
>
> The essential change is the enterFunctionNode in Lower that returns false to avoid descending into nested functions.
>
> The change in FindScopeDepths is actually a code tightening; I was poking in there for the bug first, and I realized that it can be streamlined; !compiler.isOnDemandCompilation is always true, and instead of using enterDefault with instanceof IdentNode we can just use enterIdentNode…
>
> Thanks,
>    Attila.



More information about the nashorn-dev mailing list