Review request for JDK-8149451: Fix bytecode generation issue after 8149186

Michael Haupt michael.haupt at oracle.com
Mon Feb 15 15:04:43 UTC 2016


Hi Attila,

this may have been lost in the noise, but you have two reviews, and the nightly build failure only seemed to have anything to do with your change, so you're good to go. :-)

Best,

Michael

> Am 12.02.2016 um 16:30 schrieb Michael Haupt <michael.haupt at oracle.com>:
> 
> Hi Attila,
> 
>> Am 11.02.2016 um 15:38 schrieb Attila Szegedi <szegedia at gmail.com>:
>> This is frankly maddening :-)
> 
> 
> rightfully so, as it turns out this code is not the cause of the observed nightly failures. See https://bugs.openjdk.java.net/browse/JDK-8149727. The push for 8149186 merely coincided with the first nightly breaks. Sorry about the fuss.
> 
> So, consider this a lower-case thumbs-up review. :-)
> 
> Best,
> 
> Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment>	Oracle is committed to developing practices and products that help protect the environment



More information about the nashorn-dev mailing list