Review request for JDK-8149451: Fix bytecode generation issue after 8149186

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Mon Feb 15 15:10:45 UTC 2016


+1

On 2/15/2016 8:34 PM, Michael Haupt wrote:
> Hi Attila,
>
> this may have been lost in the noise, but you have two reviews, and the nightly build failure only seemed to have anything to do with your change, so you're good to go. :-)
>
> Best,
>
> Michael
>
>> Am 12.02.2016 um 16:30 schrieb Michael Haupt <michael.haupt at oracle.com>:
>>
>> Hi Attila,
>>
>>> Am 11.02.2016 um 15:38 schrieb Attila Szegedi <szegedia at gmail.com>:
>>> This is frankly maddening :-)
>>
>> rightfully so, as it turns out this code is not the cause of the observed nightly failures. See https://bugs.openjdk.java.net/browse/JDK-8149727. The push for 8149186 merely coincided with the first nightly breaks. Sorry about the fuss.
>>
>> So, consider this a lower-case thumbs-up review. :-)
>>
>> Best,
>>
>> Michael



More information about the nashorn-dev mailing list