RFR 8160141: removed deprecated method calls in nashorn code

Attila Szegedi szegedia at gmail.com
Thu Jun 23 07:19:05 UTC 2016


A minor point: the usual idiom we use for rethrowing RuntimeException is

} catch(final RuntimeException e) {
  throw e;
} catch(final Exception e) {
  throw new RuntimeException(e);
}

instead of what you did in Global.java with an "if" in the "catch"

+1 other than that.

Attila.


On Thu, Jun 23, 2016 at 6:28 AM, Sundararajan Athijegannathan <
sundararajan.athijegannathan at oracle.com> wrote:

> Please review http://cr.openjdk.java.net/~sundar/8160141/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8160141
>
> Thanks,
>
> Sundar
>
>


More information about the nashorn-dev mailing list