RFR 8160141: removed deprecated method calls in nashorn code

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Thu Jun 23 08:45:10 UTC 2016


Hi,

Sorry I pushed with 2 reviews from Hannes and Michael.  I'll take care
of this cleanup in a later fix.

Thanks,

-Sundar

On 6/23/2016 12:49 PM, Attila Szegedi wrote:
> A minor point: the usual idiom we use for rethrowing RuntimeException is
>
> } catch(final RuntimeException e) {
>   throw e;
> } catch(final Exception e) {
>   throw new RuntimeException(e);
> }
>
> instead of what you did in Global.java with an "if" in the "catch"
>
> +1 other than that.
>
> Attila.
>
>
> On Thu, Jun 23, 2016 at 6:28 AM, Sundararajan Athijegannathan
> <sundararajan.athijegannathan at oracle.com
> <mailto:sundararajan.athijegannathan at oracle.com>> wrote:
>
>     Please review
>     http://cr.openjdk.java.net/~sundar/8160141/webrev.00/
>     <http://cr.openjdk.java.net/%7Esundar/8160141/webrev.00/> for
>     https://bugs.openjdk.java.net/browse/JDK-8160141
>
>     Thanks,
>
>     Sundar
>
>



More information about the nashorn-dev mailing list