Review request for JDK-8156714: Parsing issue with automatic semicolon insertion

Hannes Wallnoefer hannes.wallnoefer at oracle.com
Fri May 13 15:52:31 UTC 2016


Please review JDK-8156714: Parsing issue with automatic semicolon insertion:

http://cr.openjdk.java.net/~hannesw/8156714/webrev/

Comments are irrelevant for newline detection so we should ignore them 
when assigning to AbstractParser.last.

Note that this causes three endPositions to change in 
test/script/nosecurity/parserapi.js.EXPECTED. This is caused by the 
parser API no longer including trailing comments to functions.

For example consider the following code (taken from parserapi.js itself, 
this is the first changed endPosition):

function Parser() {
     // create nashorn parser
     this._parser = Parser.create();
}

// Java types used


Previously the endPosition of the Parser function would be the end of 
the trailing comment. With this change, the function's endPosition is 
before the trailing comment starts, which seems more correct.

Hannes


More information about the nashorn-dev mailing list