Review request for JDK-8167117: insert missing final keywords
Attila Szegedi
szegedia at gmail.com
Thu Oct 6 12:59:00 UTC 2016
2nd review, anyone?
> On 05 Oct 2016, at 05:41, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
>
> +1
>
> PS. One of these days, we should write an ant task using javac API to
> automate this check! Painful to manually check & fix using IDEs...
>
> -Sundar
>
> On 10/5/2016 12:06 AM, Attila Szegedi wrote:
>> Please review JDK-8167117 "insert missing final keywords" at <http://cr.openjdk.java.net/~attila/8167117/webrev.jdk9> for <https://bugs.openjdk.java.net/browse/JDK-8167117>
>>
>> Every year or so, this is done once as a kind of anti-entropy task :-)
>> It’s a big patch, but it’s just mechanical addition of missing “final” keywords everywhere (and organizing imports in only few files); tests were run afterwards.
>>
>> I have few other things in the pipeline, but my diffs were getting noisy because of my IDE inserting all the missing “final” keywords in the files I touched, so wanted to get this out of the way in one swoop.
>>
>> Thanks,
>> Attila.
>
More information about the nashorn-dev
mailing list