Review request for JDK-8167117: insert missing final keywords

Jim Laskey (Oracle) james.laskey at oracle.com
Thu Oct 6 14:26:27 UTC 2016


+1

> On Oct 4, 2016, at 3:36 PM, Attila Szegedi <szegedia at gmail.com> wrote:
> 
> Please review JDK-8167117 "insert missing final keywords" at <http://cr.openjdk.java.net/~attila/8167117/webrev.jdk9> for <https://bugs.openjdk.java.net/browse/JDK-8167117>
> 
> Every year or so, this is done once as a kind of anti-entropy task :-)
> It’s a big patch, but it’s just mechanical addition of missing “final” keywords everywhere (and organizing imports in only few files); tests were run afterwards.
> 
> I have few other things in the pipeline, but my diffs were getting noisy because of my IDE inserting all the missing “final” keywords in the files I touched, so wanted to get this out of the way in one swoop.
> 
> Thanks,
>  Attila.



More information about the nashorn-dev mailing list