Code Review Request: 7035556 DatagramSocket.java:183: warning: unreachable catch clause

[Alan Bateman]

Kurchi Hazra wrote:
> Hi,
>
> Due to a recent update in javac to issue a warning on detecting 
> unreachable code, the following warning started showing up in the jdk 
> networking code:
> ../../../src/share/classes/java/net/DatagramSocket.java:183: warning: 
> unreachable catch clause.
>
> This fix aims at removing this warning by removing the IOException. On 
> inspection, it was found that currently, the native code does not 
> throw any IOException.
>
> The fix involves updates in:
> jdk/src/share/classes/java/net/DatagramSocket.java
>
>
> Webrev: http://cr.openjdk.java.net/~chegar/7035556/webrev.00/
>
> Thanks,
> -Kurchi
Kurchi - one suggestion is to close the UDP socket in the event that the 
bind fails. That would be nicer than leaving it to the impl's finalizer.

-Alan.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20110722/cda9c7f0/attachment.html