<net-dev> Java_java_net_Inet6AddressImpl_isReachable0 is returning false for InetAdress 0.0.0.0
Alan Bateman
Alan.Bateman at oracle.com
Wed May 2 11:10:00 PDT 2012
On 27/04/2012 10:30, Deven You wrote:
> Hi Alan,
>
> I have updated the patch and test[1] for ::0. Please review it.
>
> [1] http://cr.openjdk.java.net/~littlee/OJDK-217/webrev.03/
>
> Thanks a lot!
Minor indentation issues, Inet4AddressImpl.c L684 and net_util_md.c
L950. No need to re-generate the webrev for this but would be good to
resolve before this is pushed.
On the test then does testing if ::0 is reachable work when IPv6 is
disabled? One idea to give better test cover is to run the test twice,
the second time with IPv6 disabled, ie:
@run main PingThis
@run main/othervm -Djava.net.preferIPv4Stack=true PingThis
Otherwise looks fine to me.
-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20120502/e0e50bcc/attachment.html
More information about the net-dev
mailing list