<net-dev> Java_java_net_Inet6AddressImpl_isReachable0 is returning false for InetAdress 0.0.0.0

[Chris Hegarty]

On 02/05/2012 19:10, Alan Bateman wrote:
> On 27/04/2012 10:30, Deven You wrote:
>> Hi Alan,
>>
>> I have updated the patch and test[1] for ::0. Please review it.
>>
>> [1] http://cr.openjdk.java.net/~littlee/OJDK-217/webrev.03/
>>
>> Thanks a lot!
> Minor indentation issues, Inet4AddressImpl.c L684 and net_util_md.c
> L950. No need to re-generate the webrev for this but would be good to
> resolve before this is pushed.
>
> On the test then does testing if ::0 is reachable work when IPv6 is
> disabled? One idea to give better test cover is to run the test twice,
> the second time with IPv6 disabled, ie:
>
> @run main PingThis
> @run main/othervm -Djava.net.preferIPv4Stack=true PingThis
>
> Otherwise looks fine to me.

Thanks for the detailed review Alan. I agree with your comments, and the 
changes look fine to me too.

On the test, it would be good to run with it with 
-Djava.net.preferIPv4Stack=true too, but ::0 should not be reachable. I 
guess the test should check if preferIPv4Stack=true and skip testing 
with ::0. Or only add ::0 to addresses if !preferIPv4Stack?

-Chris.


>
> -Alan
>
>