RFR: 8029354: URLPermission.<init> throws llegalArgumentException: Invalid characters in hostname

Alan Bateman Alan.Bateman at oracle.com
Mon Dec 2 07:21:55 PST 2013


On 02/12/2013 14:33, Michael McMahon wrote:
>
> The second webrev is at link below. This is somewhat simpler now.
>
> I think it still needs a spec change though. So, I would like to propose
> that to the CCC asap.
>
> http://cr.openjdk.java.net/~michaelm/8029354/webrev.2/
>
> I added a test that uses the protocol handler. it should be reliable 
> enough
> as it does not actually go as far as opening an actual socket connection.
>
This does look much simpler and I think the approach is good.

A minor point on the wording, maybe "when creating a URLPermission" 
rather than "at object creation".

Also maybe "of this this" would be better as "defined by this class".

Does the userinfo = "" case need special handling now?

-Alan.




More information about the net-dev mailing list