RFR: 8029354: URLPermission.<init> throws llegalArgumentException: Invalid characters in hostname

[Michael McMahon]

On 02/12/13 15:21, Alan Bateman wrote:
> On 02/12/2013 14:33, Michael McMahon wrote:
>>
>> The second webrev is at link below. This is somewhat simpler now.
>>
>> I think it still needs a spec change though. So, I would like to propose
>> that to the CCC asap.
>>
>> http://cr.openjdk.java.net/~michaelm/8029354/webrev.2/
>>
>> I added a test that uses the protocol handler. it should be reliable 
>> enough
>> as it does not actually go as far as opening an actual socket 
>> connection.
>>
> This does look much simpler and I think the approach is good.
>
> A minor point on the wording, maybe "when creating a URLPermission" 
> rather than "at object creation".
>
> Also maybe "of this this" would be better as "defined by this class".
>

That's fine. I've updated the docs as suggested.

> Does the userinfo = "" case need special handling now?
>

No. But, I've added a test for empty userinfo now like http://@foo.com/
is the same as http://foo.com

Michael.

> -Alan.
>