Code review: 8010464: Evolve java networking same origin policy

[Michael McMahon]

On 13/05/13 11:08, Chris Hegarty wrote:
>
> On 12/05/2013 08:13, Alan Bateman wrote:
>> ....
>> At a high-level it would be nice if the fields were final but I guess
>> the parsing of actions and being serialized complicates this.
>
> This would be my preference too. You could use the serialization proxy 
> pattern, and with some restructuring I think the fields could be made 
> final. But, I ok with what you have. We can re-visit later to see if 
> this makes sense.
>

Yes, maybe revisit later, especially if this means using sun.misc.Unsafe 
again. I'm still not
convinced about the benefit of that (being worth the ugliness)

> I don't see where the socketPermission field is used in 
> HttpURLConnection, I suspect it should be set in URLtoSocketPermission?
>

right, good catch.

> I think it should be possible to add the GPL header to the new test 
> policy files.
>

okay

Thanks!
Michael