RFR: Inet[4|6]Address native initializing code should check fieldID values

Chris Hegarty chris.hegarty at oracle.com
Tue Nov 5 12:49:21 PST 2013


> On 5 Nov 2013, at 20:39, Michael McMahon <michael.x.mcmahon at oracle.com> wrote:
> 
>> On 05/11/13 19:38, Chris Hegarty wrote:
>> Another installment of checks for return values from
>> GetFieldID, and friends, to follow up on last weeks work [1].
>> 
>> http://cr.openjdk.java.net/~chegar/netNullChecks/webrev/
>> 
>> There are more cleanups to come along the same lines, but I'd like to keep these changes small and confined for now.
>> 
>> -Chris.
>> 
>> [1] http://mail.openjdk.java.net/pipermail/net-dev/2013-October/007698.html
> 
> Just curious about the CHECK_NULLs that are removed. Is that due to some warning
> about redundant code?

No, just caught my eye when going through this. As you said they are redundant.

I have more, similar, changes to come in this area but would to move these through increamantally.

-Chris.

> 
> Michael



More information about the net-dev mailing list