RFR: Inet[4|6]Address native initializing code should check fieldID values

Chris Hegarty chris.hegarty at oracle.com
Tue Nov 5 12:56:48 PST 2013


> On 5 Nov 2013, at 20:47, roger riggs <roger.riggs at oracle.com> wrote:
> 
> H Michael,
> 
> If I remember rightly, CHECK_NULL tests for an exception and conditionally
> does an early return from the function. So testing just before an unconditional return is unnecessary.
> 
> (These look ok to me;  not a Reviewer)

Thanks for the review Roger.

-Chris.

> 
> Roger
> 
>> On 11/5/2013 3:39 PM, Michael McMahon wrote:
>>> On 05/11/13 19:38, Chris Hegarty wrote:
>>> Another installment of checks for return values from
>>> GetFieldID, and friends, to follow up on last weeks work [1].
>>> 
>>> http://cr.openjdk.java.net/~chegar/netNullChecks/webrev/
>>> 
>>> There are more cleanups to come along the same lines, but I'd like to keep these changes small and confined for now.
>>> 
>>> -Chris.
>>> 
>>> [1] http://mail.openjdk.java.net/pipermail/net-dev/2013-October/007698.html
>> 
>> Just curious about the CHECK_NULLs that are removed. Is that due to some warning
>> about redundant code?
>> 
>> Michael
> 



More information about the net-dev mailing list