RFR: 8154238: Drop code to support Windows XP in windows socket impl

Claes Redestad claes.redestad at oracle.com
Mon Apr 18 10:01:16 UTC 2016


On 04/18/2016 11:45 AM, Chris Hegarty wrote:
> On 14/04/16 13:49, Claes Redestad wrote:
>> Hi,
>>
>> more code in the Windows socket implementation that can be dropped
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8154238
>> Webrev: http://cr.openjdk.java.net/~redestad/8154238/webrev.01/
>
> The changes look fine.

Thanks Chris!

>
> Maybe the bug description should be updated a before pushing,
> it looks like it affects only legacy networking code and not
> NIO. Maybe "... and async channels" ?

Not sure where you saw NIO mentioned.

Does  "Drop code to support Windows XP in windows socket and async 
channel impls" sound better?

Thanks!

/Claes


More information about the net-dev mailing list