RFR: 8154238: Drop code to support Windows XP in windows socket impl
Chris Hegarty
chris.hegarty at oracle.com
Mon Apr 18 10:30:43 UTC 2016
On 18/04/16 11:09, Claes Redestad wrote:
> On 04/18/2016 12:06 PM, Chris Hegarty wrote:
>> On 18/04/16 11:01, Alan Bateman wrote:
>>> On 18/04/2016 10:45, Chris Hegarty wrote:
>>>>
>>>> The changes look fine.
>>>>
>>>> Maybe the bug description should be updated a before pushing,
>>>> it looks like it affects only legacy networking code and not
>>>> NIO. Maybe "... and async channels" ?
>>> The changes to the NIO code look okay but probably should be split into
>>> their own issue for tracking purposes.
>>
>> That works for me.
>>
>> -Chris.
>
> New webrev only with the PlainSocket changes:
>
> http://cr.openjdk.java.net/~redestad/8154238/webrev.02/
Looks fine.
-Chris
> I'll file a bug and send out a RFR for the other changes shortly
>
> /Claes
More information about the net-dev
mailing list