RFR:8170868: DefaultProxySelector should use system defaults on Windows, MacOS and Gnome

[Thomas Stüfe]

On Fri, Dec 23, 2016 at 11:25 AM, Volker Simonis <volker.simonis at gmail.com>
wrote:

> On Thu, Dec 22, 2016 at 9:41 PM, Thomas Stüfe <thomas.stuefe at gmail.com>
> wrote:
> > Hi Arno,
> >
> > good job, this is a nice addition!
> >
> > Some remarks/questions (not a full review):
> >
> > 1) The naming of the unix...DefaultProxySelector.c is confusing. Could we
> > rename it to gnome/../DefaultProxySelector?
> >
>
> I don't think that would be easy. "unix" is actually a OS-category
> which includes all *nix-like operatng systems and Gnome is not an OS
> category in my opinion. I also think that in the future the
> DefaultProxySelector.c may also support other Unix desktop
> environments like for example KDE so leaving it under unix is fine for
> me.
>

Fine, but in that case there should not be a separate MacOS implementation
either, because MacOs is Unix too. If the future plan is to lump all Unix
implementations together in this one file, just excluding MacOS feels
arbitrary.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/net-dev/attachments/20161223/cfe02f5a/attachment.html>