RFR:8170868: DefaultProxySelector should use system defaults on Windows, MacOS and Gnome

[Chris Hegarty]

> On 23 Dec 2016, at 15:06, Thomas Stüfe <thomas.stuefe at gmail.com> wrote:
> 
> On Fri, Dec 23, 2016 at 11:25 AM, Volker Simonis <volker.simonis at gmail.com <mailto:volker.simonis at gmail.com>> wrote:
> On Thu, Dec 22, 2016 at 9:41 PM, Thomas Stüfe <thomas.stuefe at gmail.com <mailto:thomas.stuefe at gmail.com>> wrote:
> > ...
> > 1) The naming of the unix...DefaultProxySelector.c is confusing. Could we
> > rename it to gnome/../DefaultProxySelector?
> >
> 
> I don't think that would be easy. "unix" is actually a OS-category
> which includes all *nix-like operatng systems and Gnome is not an OS
> category in my opinion. I also think that in the future the
> DefaultProxySelector.c may also support other Unix desktop
> environments like for example KDE so leaving it under unix is fine for
> me.

+1  The code here applies to both Solaris and Linux, but not
OS X. It’s a little unusual, but seems fine.

> Fine, but in that case there should not be a separate MacOS implementation either, because MacOs is Unix too. If the future plan is to lump all Unix implementations together in this one file, just excluding MacOS feels arbitrary.

There is a directory, ‘unix’, for generic Unix-like OS’s, and also
an OS-specific directory for code that is specific for a particular
Unix variant. It’s a little unusual here that two OS’s, Solaris and
Linux, share a common implementation, for Gnome, while OS
X has its own implementation, but what Arno has done seems
reasonable.

-Chris.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/net-dev/attachments/20161223/cd9dc7b0/attachment-0001.html>