RFR 8133704/9, java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.java may fail with address already in use

Chris Hegarty chris.hegarty at oracle.com
Fri Jan 8 14:08:26 UTC 2016


Hi Felix,

On 08/01/16 08:36, Felix Yang wrote:
> Hi all,
>     please review the fix for
> java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.java
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8133704
> Webrev: http://cr.openjdk.java.net/~xiaofeya/8133704/webrev.00

This looks good.  I think 'port' can be final ( rather than
volatile ), as can 'socket'. No need to regenerate the webrev.

-Chris.

> It is using hard-coded port 4445 for the server side. This fix updates
> the test to use a port number that is automatically allocated.
>
> Thanks,
> Felix


More information about the net-dev mailing list