RFR 8133704/9, java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.java may fail with address already in use

Felix Yang felix.yang at oracle.com
Mon Jan 11 08:40:34 UTC 2016


Hi Chris,
     thank you very much!

-Felix
On 2016/1/8 22:08, Chris Hegarty wrote:
> Hi Felix,
>
> On 08/01/16 08:36, Felix Yang wrote:
>> Hi all,
>>     please review the fix for
>> java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.java 
>>
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8133704
>> Webrev: http://cr.openjdk.java.net/~xiaofeya/8133704/webrev.00
>
> This looks good.  I think 'port' can be final ( rather than
> volatile ), as can 'socket'. No need to regenerate the webrev.
>
> -Chris.
>
>> It is using hard-coded port 4445 for the server side. This fix updates
>> the test to use a port number that is automatically allocated.
>>
>> Thanks,
>> Felix



More information about the net-dev mailing list