RFR: 8158651: ConcurrentModification exceptions in httpclient

Michael McMahon michael.x.mcmahon at oracle.com
Fri Jun 3 15:08:24 UTC 2016


Hi Roger,

All access to the list is synchronized.

Yes, I should also remove that printf. It's not required.

Pavel also suggested changing the LinkedList to an ArrayList
when I told him the size is nearly always small (1 or 2 elements).
So, I will also change that.

Thanks
Michael.


On 03/06/16 16:06, Roger Riggs wrote:
> Hi Michael,
>
> Looks ok as long as the response_cfs list can't be shrunk by a 
> different thread.  (cfs_len can be stale).
>
> And 577: probably a printf to system.err isn't the ultimate in 
> robustness or debugging.
>
> Roger
>
>
>
>
> On 6/3/2016 10:40 AM, Michael McMahon wrote:
>> Could I get the following small change reviewed please?
>>
>> http://cr.openjdk.java.net/~michaelm/8158651/webrev.1/
>>
>> The exception has been seen in some tests failing intermittently.
>> So, I have not added a new test
>>
>> The failure occurs in Http2Connection but a similar case
>> was found in Stream.java
>>
>> Thanks
>> Michael
>>
>> PS I will get back to API review comments next week.
>



More information about the net-dev mailing list