Re: RFR JDK-8158690 "GET request via HTTP/2 has a huge delays due to Nagle’s Algorithm and Delayed ACK clash"

[Chris Hegarty]

Pushed:
  http://hg.openjdk.java.net/jdk9/dev/jdk/rev/1f3481f377e6

-Chris.

> On 23 Jun 2016, at 10:41, Chris Hegarty <chris.hegarty at oracle.com> wrote:
> 
> Sergey and I discuss this off-line and the potential performance improvement
> here is very significant; raises performance from 25 request/sec to 6000
> requests/sec in one particular test.
> 
> I think we should proceed with this change, unless there are strong objections.
> 
> We can revisit this later, if necessary. And/Or make implementation changes
> if issues arise from this.
> 
> -Chris.
> 
>> On 21 Jun 2016, at 06:56, Chris Hegarty <chris.hegarty at oracle.com> wrote:
>> 
>> On 20 Jun 2016, at 21:36, Sergey Kuksenko <sergey.kuksenko at oracle.com> wrote:
>>> 
>>> Hi,
>>> 
>>> Could you please review the following fix for JDK-8158690?
>>> 
>>> http://cr.openjdk.java.net/~skuksenko/jep110/8158690/webrev.00/
>>> 
>>> Fix solves the following issue: https://bugs.openjdk.java.net/browse/JDK-8158690
>> 
>> Hmmm…..  I’m not sure that disabling Nagle is the right thing to do,
>> at least not without doing further investigation about the size / chunks
>> of data that can be sent.  Though I do note that the old
>> HtpURLConnection implementation does set setTcpNoDelay(true),
>> while buffering the data to be written.
>> 
>> -Chris.
>