RFR: JDK-8134577 - Eliminate or standardize a replacement for sun.net.spi.nameservice.NameServiceDescriptor

[Mark Sheppard]

Hi Chris,
   thanks for the feedback, I'll make the appropriate amendments

regards
Mark

On 18/03/2016 11:17, Chris Hegarty wrote:
> Hi Mark,
>
> This mainly looks good. Some specific comments on InetAddress.
>
>   - Why did you add transient to this field?
>      private static TRANSIENT NameService nameService = null;
>
>   - There will be support for IPv6, right?  There is a comment
>     in the code that says otherwise.
>
>   - jdk.net.hosts.file pointing to a file that does not exist
>     results in an UHE always, right? There is a comment in the
>     code that says otherwise.
>
> I incorporated my comments, along with some stylistic and
> proposed re-wordings, into a webrev for your convenience:
>
>
> http://cr.openjdk.java.net/~chegar/8134577_comments/src/java.base/share/classes/java/net/InetAddress.java.sdiff.html 
>
>
> -Chris.
>
> On 07/01/16 15:38, Alan Bateman wrote:
>>
>>
>> On 07/01/2016 10:44, Mark Sheppard wrote:
>>> again thanks for the review and feedback, Alan
>>>
>>> patch amended as suggested
>>> http://cr.openjdk.java.net/~msheppar/8134577/webrev.08/
>>>
>>> removed File.exists test in createNameService - lookup methods in
>>> HostsFileNameService already throw UHE for FileNotFoundException
>>>
>>> InetAddress.impl marked final
>>>
>>> removed references to JNDI
>>>
>>> added test for non-existent hosts file
>>>
>> I think InetAddress looks okay now. At some point we should do some
>> clean-up on this code but I think it's okay for now.
>>
>> Before you push this then can you create a bug to track the issue with
>> ExtensionsWithLDAP.java and put that issue number in the exclude list?
>>
>> -Alan