RFR: JDK-8134577 - Eliminate or standardize a replacement for sun.net.spi.nameservice.NameServiceDescriptor
Alan Bateman
Alan.Bateman at oracle.com
Fri Mar 18 14:42:25 UTC 2016
On 18/03/2016 11:17, Chris Hegarty wrote:
> Hi Mark,
>
> This mainly looks good. Some specific comments on InetAddress.
>
> - Why did you add transient to this field?
> private static TRANSIENT NameService nameService = null;
>
> - There will be support for IPv6, right? There is a comment
> in the code that says otherwise.
>
> - jdk.net.hosts.file pointing to a file that does not exist
> results in an UHE always, right? There is a comment in the
> code that says otherwise.
>
> I incorporated my comments, along with some stylistic and
> proposed re-wordings, into a webrev for your convenience:
>
>
> http://cr.openjdk.java.net/~chegar/8134577_comments/src/java.base/share/classes/java/net/InetAddress.java.sdiff.html
>
I think this is good to go.
-Alan
More information about the net-dev
mailing list