RFR 8156825: java/net/httpclient/BasicWebSocketAPITest.java failed with "java.lang.AssertionError"

Roger Riggs Roger.Riggs at Oracle.com
Mon May 16 14:11:27 UTC 2016


Hi Michael,

+1

HttpClientImpl.java: Unless a large number of classes are needed, 
individual imports are preferred.

(Maybe the IDE did that for you, in which the IDE should be reconfigured.)

Roger


On 5/16/2016 7:07 AM, Michael McMahon wrote:
> Could I get the following change reviewed please? There are three 
> small changes
>
> 1) enhancements to RawChannel API used by websocket implementation
>
> 2) fix the test case problem where channel might not be in 
> non-blocking mode
>     (also remove erroneous asssertion check)
>
> 3) Remove (unused) and unintentionally public HttpHeaders1 type
>
> http://cr.openjdk.java.net/~michaelm/8156825/webrev.1/
>
> Thanks,
> Michael



More information about the net-dev mailing list