RFR 8156825: java/net/httpclient/BasicWebSocketAPITest.java failed with "java.lang.AssertionError"

Michael McMahon michael.x.mcmahon at oracle.com
Mon May 16 14:09:41 UTC 2016


Thanks Roger. What would the consensus be on what 'a large number' is?

- Michael

On 16/05/16 15:11, Roger Riggs wrote:
> Hi Michael,
>
> +1
>
> HttpClientImpl.java: Unless a large number of classes are needed, 
> individual imports are preferred.
>
> (Maybe the IDE did that for you, in which the IDE should be 
> reconfigured.)
>
> Roger
>
>
> On 5/16/2016 7:07 AM, Michael McMahon wrote:
>> Could I get the following change reviewed please? There are three 
>> small changes
>>
>> 1) enhancements to RawChannel API used by websocket implementation
>>
>> 2) fix the test case problem where channel might not be in 
>> non-blocking mode
>>     (also remove erroneous asssertion check)
>>
>> 3) Remove (unused) and unintentionally public HttpHeaders1 type
>>
>> http://cr.openjdk.java.net/~michaelm/8156825/webrev.1/
>>
>> Thanks,
>> Michael
>



More information about the net-dev mailing list