RFR(s): 8169196: [TESTBUG] Three tests from sun/net/www have undeclared dependencies

Daniel Fuchs daniel.fuchs at oracle.com
Thu Nov 3 15:30:03 UTC 2016


Hi Sergey,

Great to get rid of yet another shell script.

The change looks good in general - except for NoNTLM.java:

I don't think the test should have @modules jdk.security.auth
as the test is precisely supposed to be able to run without it
(+ lines 218-223 are probably obsolete and I suspect they should
    be removed - but that is for another day).

best regards,

-- daniel

On 03/11/16 13:48, Sergei Kovalev wrote:
> Hi Team,
>
> Please review one more small fix for module dependencies issue.
>
> Bug ID: https://bugs.openjdk.java.net/browse/JDK-8169196
> WebRev: http://cr.openjdk.java.net/~skovalev/8169196/webrev.00/index.html
>
> Added missed dependency on jdk.httpserver. Also shell test converted to
> pure java test.
>



More information about the net-dev mailing list