RFR(s): 8169196: [TESTBUG] Three tests from sun/net/www have undeclared dependencies

[Sergei Kovalev]

Daniel,

I case I remove lines 218-223 and disable jdk.security.auth module the 
test fails with an Exception:

Expect client to choose: Basic
HTTP/1.1 401 Unauthorized
Content-Length: 0
Connection: close
WWW-Authenticate: Basic realm="wallyworld"
WWW-Authenticate: NTLM


Server received Authorization header: NTLM 
TlRMTVNTUAABAAAAB4IIAAAAAAAAAAAAAAAAAAAAAAA=
STDERR:
java.lang.RuntimeException: Unexpected value
         at NoNTLM.test(NoNTLM.java:174)
         at NoNTLM.main(NoNTLM.java:229)
         at 
jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(java.base at 9-ea/Native 
Method)
         at 
jdk.internal.reflect.NativeMethodAccessorImpl.invoke(java.base at 9-ea/NativeMethodAccessorImpl.java:62)
         at 
jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(java.base at 9-ea/DelegatingMethodAccessorImpl.java:43)
         at java.lang.reflect.Method.invoke(java.base at 9-ea/Method.java:537)
         at 
com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:110)
         at java.lang.Thread.run(java.base at 9-ea/Thread.java:844)

JavaTest Message: Test threw exception: java.lang.RuntimeException: 
Unexpected value
JavaTest Message: shutting down test

Looks like the module also requires for www authentication in other pice 
of code.

-- 
With best regards,
Sergei

03.11.16 18:30, Daniel Fuchs wrote:
> Hi Sergey,
>
> Great to get rid of yet another shell script.
>
> The change looks good in general - except for NoNTLM.java:
>
> I don't think the test should have @modules jdk.security.auth
> as the test is precisely supposed to be able to run without it
> (+ lines 218-223 are probably obsolete and I suspect they should
>    be removed - but that is for another day).
>
> best regards,
>
> -- daniel
>
> On 03/11/16 13:48, Sergei Kovalev wrote:
>> Hi Team,
>>
>> Please review one more small fix for module dependencies issue.
>>
>> Bug ID: https://bugs.openjdk.java.net/browse/JDK-8169196
>> WebRev: 
>> http://cr.openjdk.java.net/~skovalev/8169196/webrev.00/index.html
>>
>> Added missed dependency on jdk.httpserver. Also shell test converted to
>> pure java test.
>>