Ping: RFR(S): 8163181: Further improvements for Unix NetworkInterface native implementation

[Chris Hegarty]

Apologies Christoph, this dropped off my list and I forgot to get back to it.

> On 2 Sep 2016, at 08:22, Langer, Christoph <christoph.langer at sap.com> wrote:
> 
> Hi (Mark or Chris?),
>  
> as this RFR is outstanding for quite a while and it merely is a minor change which only cleans up coding, would you mind to review it that I can get it off my list?
>  
> The only major thing probably is, that calls to getMacAddress don’t need a socket anymore and sockets are only opened for platforms where an ioctl is done to determine the MacAddress.
>  
> As I’ve said, I’ve tested it on the Linux/Unix platforms.
>  
> Thanks a lot
> Christoph
>  
> From: Langer, Christoph 
> Sent: Montag, 22. August 2016 15:30
> To: 'net-dev at openjdk.java.net' <net-dev at openjdk.java.net>
> Subject: RE: Ping: RFR(S): 8163181: Further improvements for Unix NetworkInterface native implementation
>  
> Hi,
>  
> I made a little update to my change: http://cr.openjdk.java.net/~clanger/webrevs/8163181.2/


Your changes look fine to me. This is a natural cleanup now that we have
moved away from ioctl on some platforms.

I will submit your patch to our internal build and test system, and report
back the results later today.

-Chris.


> Merely comments and a minor AIX specific correction.
>  
> Thanks in advance for reviewing
> Christoph
>  
>  
> From: Langer, Christoph 
> Sent: Dienstag, 16. August 2016 14:49
> To: 'net-dev at openjdk.java.net' <net-dev at openjdk.java.net>
> Subject: Ping: RFR(S): 8163181: Further improvements for Unix NetworkInterface native implementation
>  
> Ping: Can I get a review for this small set of changes please?
>  
> Thanks
> Christoph
>  
> From: Langer, Christoph 
> Sent: Donnerstag, 4. August 2016 15:04
> To: net-dev at openjdk.java.net
> Subject: RFR(S): 8163181: Further improvements for Unix NetworkInterface native implementation
>  
> Hi,
>  
> I had made a few more cleanups when I was working on NetworkInterface.c which I thought are worth contributing.
>  
> Please review: http://cr.openjdk.java.net/~clanger/webrevs/8163181.1/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8163181
>  
> As always, changes were built and tested on Linux, AIX, Solaris and Mac.
>  
> Thanks
> Christoph