Ping: RFR(S): 8163181: Further improvements for Unix NetworkInterface native implementation

[Mark Sheppard]

have had a look through the changes twice, and they look fine ... i'll 
apply the patch and run a regression build to confirm

the moving of int flags on 919 to a conditional block,  I expect to 
cause a strict compile error in my solaris env, so need to check that

regards
Mark

On 02/09/2016 08:22, Langer, Christoph wrote:
>
> Hi (Mark or Chris?),
>
> as this RFR is outstanding for quite a while and it merely is a minor 
> change which only cleans up coding, would you mind to review it that I 
> can get it off my list?
>
> The only major thing probably is, that calls to getMacAddress don’t 
> need a socket anymore and sockets are only opened for platforms where 
> an ioctl is done to determine the MacAddress.
>
> As I’ve said, I’ve tested it on the Linux/Unix platforms.
>
> Thanks a lot
>
> Christoph
>
> *From:*Langer, Christoph
> *Sent:* Montag, 22. August 2016 15:30
> *To:* 'net-dev at openjdk.java.net' <net-dev at openjdk.java.net>
> *Subject:* RE: Ping: RFR(S): 8163181: Further improvements for Unix 
> NetworkInterface native implementation
>
> Hi,
>
> I made a little update to my change: 
> http://cr.openjdk.java.net/~clanger/webrevs/8163181.2/ 
> <http://cr.openjdk.java.net/%7Eclanger/webrevs/8163181.2/>
>
> Merely comments and a minor AIX specific correction.
>
> Thanks in advance for reviewing
>
> Christoph
>
> *From:*Langer, Christoph
> *Sent:* Dienstag, 16. August 2016 14:49
> *To:* 'net-dev at openjdk.java.net' <net-dev at openjdk.java.net 
> <mailto:net-dev at openjdk.java.net>>
> *Subject:* Ping: RFR(S): 8163181: Further improvements for Unix 
> NetworkInterface native implementation
>
> Ping: Can I get a review for this small set of changes please?
>
> Thanks
>
> Christoph
>
> *From:*Langer, Christoph
> *Sent:* Donnerstag, 4. August 2016 15:04
> *To:* net-dev at openjdk.java.net <mailto:net-dev at openjdk.java.net>
> *Subject:* RFR(S): 8163181: Further improvements for Unix 
> NetworkInterface native implementation
>
> Hi,
>
> I had made a few more cleanups when I was working on 
> NetworkInterface.c which I thought are worth contributing.
>
> Please review: http://cr.openjdk.java.net/~clanger/webrevs/8163181.1/ 
> <http://cr.openjdk.java.net/%7Eclanger/webrevs/8163181.1/>
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8163181 
> <https://bugs.openjdk.java.net/browse/JDK-8163181>
>
> As always, changes were built and tested on Linux, AIX, Solaris and Mac.
>
> Thanks
>
> Christoph
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/net-dev/attachments/20160902/f62c0fc2/attachment.html>