RFR [11] 8198358 : Align organization of DualStackPlainSocketImpl with TwoStacksPlainSocketImp [win]

[Chris Hegarty]

Ivan,

Thank you for persisting with this.

> On 23 Mar 2018, at 19:09, Ivan Gerasimov <ivan.gerasimov at oracle.com> wrote:
> 
> Hello!
> 
> I reverted the direction of the patch, and now TwoStacks implementation is changed to mimic DualStack.
> As part of this fix, I also added another @run line to several tests to execute them with the option -Djava.net.preferIPv4Stack=true to make sure both implementations work as expected.
> 
> After this patch the diff shows difference in only hundred lines of the two implementations, so it will be easy to merge them together on the next step.
> 
> For reference, here's the combined webrev:
> http://cr.openjdk.java.net/~igerasim/8198358/03/webrev/ <http://cr.openjdk.java.net/~igerasim/8198358/03/webrev/>

I think this is good. And thanks for the additional test coverage, this is great.

You asked previously about maybe creating a branch in the sandbox for
this work. If you could that would facilitate working on the next step, the
changes could then be folded and pushed into the mainline. This has the
added benefit of reducing merge costs for the loom project.

-Chris.

> With kind regards,
> Ivan
> 
> On 3/9/18 3:50 AM, Chris Hegarty wrote:
>> Ivan,
>> 
>> Thanks for breaking up the changes, it makes it easier to review.
>> 
>> I disagree with changing DualStackPlainSocketImp to conform with
>> TwoStacks (and unix/PlainSocketImpl). I would prefer to move the
>> latter to the former. Specifically, around the use of fdAccess.
>> 
>> -Chris.
>> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/net-dev/attachments/20180323/1c59cfb9/attachment.html>