RFR [11] 8198358 : Align organization of DualStackPlainSocketImpl with TwoStacksPlainSocketImp [win]

[Chris Hegarty]

> On 23 Mar 2018, at 21:55, Chris Hegarty <chris.hegarty at oracle.com> wrote:
> 
>> For reference, here's the combined webrev:
>> http://cr.openjdk.java.net/~igerasim/8198358/03/webrev/ <http://cr.openjdk.java.net/~igerasim/8198358/03/webrev/>
> 
> I think this is good. And thanks for the additional test coverage, this is great.

Actually, there is a couple of places in the new native code that
has the following pattern:

     if (sa.sa.sa_family != AF_INET) {
         JNU_ThrowByName(env, JNU_JAVANETPKG "SocketException",
                         "Protocol family not supported");
         NET_SocketClose(newfd);
         return -1;
   }

I would like to remove the NET_SocketClose, and allow the
exception propagating at the Java-level be responsible for 
closing the socket, which will then do so in cooperation
with the socket cleaner ( it will effectively cancel the cleaner ).

-Chris.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/net-dev/attachments/20180325/c9caa1a1/attachment.html>