RFR [11] 8198358 : Align organization of DualStackPlainSocketImpl with TwoStacksPlainSocketImp [win]
Chris Hegarty
chris.hegarty at oracle.com
Tue Mar 27 17:32:02 UTC 2018
> On 27 Mar 2018, at 18:30, Ivan Gerasimov <ivan.gerasimov at oracle.com> wrote:
>
> Thank you Christoph and Chris for the review!
>
> I made the following suggested changes:
> - fdAccess made private static final in both TwoStacks and DualStack.
> - removed redundant check IS_NULL(iaObj) at bind0 (indeed, the address was already checked at Java level).
>
> For now, I would prefer to keep the checks for family == IPv4 as they are.
> I totally agree they should be moved to Java, but I'm planning to do this during the TwoStacks-DualStack merge step.
>
> I'm also planning to add a regtest to make sure that Inet6Address is rejected when fed to a IPv4-only socked.
>
> Are we good to push now?
Yes.
-Chris.
More information about the net-dev
mailing list